Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New switches for 'add' #41

Open
severach opened this issue Jun 30, 2018 · 1 comment
Open

New switches for 'add' #41

severach opened this issue Jun 30, 2018 · 1 comment
Labels
enhancement this could improve the capabilities/design of the program good first issue this is a good issue for starting contributors
Milestone

Comments

@severach
Copy link

--update, only add files not already present. This allows me to add *.pkg.tar.xz
--symlink, symlink files instead of copying. This keeps me from having two copies around
--srcinfo, add all current version filenames found in .SRCINFO

With symlink you'll need an autoclean that removes broken symlinks from the repo and db.

@cassava
Copy link
Owner

cassava commented Apr 28, 2019

Hey @severach, sorry for the long delay in responding.

  • --update -- If you can live with hardlinks, using the --link or -l argument for the add command will be just as performant.

  • --symlink -- I added the --link flag, which tries to create a hardlink before copying. I'm not quite ready yet for actually supporting symlinks, as I feel this makes repoctl a good deal more complex for handling routine tasks. See the devel branch.

  • --srcinfo -- How is this better or different to repoctl add *.pkg.tar.xz? I assume all packages in a directory will be generated from that PKGBUILD file. Or would you like to use this to get a specific version of package added? I am hesitant however to add support for this, as it would require being able to parse .SRCINFO files. I don't see this as being very useful for most users of repoctl.

If this frustrates you enough, you are welcome to try your hand at implementing this yourself. You would have to look at cmd/repoctl/add.go and actions.go, and if you want to find all packages in a certain directory, you could also take advantage of the functions defined in find.go.

@cassava cassava added the enhancement this could improve the capabilities/design of the program label Apr 28, 2019
@cassava cassava added this to the Version 0.22 milestone Aug 6, 2020
@cassava cassava added the good first issue this is a good issue for starting contributors label Aug 30, 2020
@cassava cassava modified the milestones: Version 0.22, Version 0.23 Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this could improve the capabilities/design of the program good first issue this is a good issue for starting contributors
Projects
None yet
Development

No branches or pull requests

2 participants