Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection prompt shows incorrect site #157

Open
George-cl opened this issue Oct 10, 2021 · 6 comments
Open

Connection prompt shows incorrect site #157

George-cl opened this issue Oct 10, 2021 · 6 comments
Assignees
Labels
bug Something isn't working ui/ux

Comments

@George-cl
Copy link
Contributor

Sometimes the connection prompt will show the wrong site (usually another the URL of another tab in the window).

@George-cl George-cl added the bug Something isn't working label Oct 10, 2021
@George-cl George-cl added this to the 1.4.2 milestone Oct 10, 2021
@hoffmannjan
Copy link
Contributor

@George-cl any steps to easily reproduce this? Does this happen when tabs are being changed quickly?

@George-cl
Copy link
Contributor Author

@George-cl any steps to easily reproduce this? Does this happen when tabs are being changed quickly?

@hoffmannjan, not reliably - I've had it happen occasionally, and there's now been a few reports on Discord. I'd say just to have a few tabs open and switch between.

Maybe this is something we'll just need to keep an eye out for and try to diagnose as and when it happens?

@hoffmannjan
Copy link
Contributor

@George-cl thanks, I will try to play with Signer for a while and post an update :)

@George-cl George-cl modified the milestones: Signer 1.4.2, Signer 1.4.3 Nov 1, 2021
@George-cl George-cl modified the milestones: Signer 1.4.3, Signer 1.4.4 Nov 10, 2021
@George-cl George-cl modified the milestones: Signer 1.4.4, Signer 1.4.5 Nov 22, 2021
@George-cl George-cl removed this from the Signer 1.4.5 milestone Dec 21, 2021
@mrkara
Copy link
Collaborator

mrkara commented Apr 11, 2022

It's being reported again. I've also experienced the same issue while playing with the friendly market yesterday.

reported

@mrkara
Copy link
Collaborator

mrkara commented Apr 11, 2022

@George-cl @hoffmannjan Here are the steps to repro:

  • Open chrome, and unlock your Signer vault
  • Go to facebook.com
  • Open a second tab and visit https://www.friendly.market/pool
  • Click the Connect Wallet button on the page
  • Select the Casper Signer option on the Connect Wallet dialog
  • Wait for the Signer's Connection Request pop-up, but do not click the Connect or the Cancel button, and keep the popup open
  • Swicth to the facebook.com tab
  • Observe that the url on the popup has changed to facebook.com
  • If you keep switching back and forth between the tabs, you will see that the url on the connection popup gets updated every time

@gRoussac
Copy link

Hi, this issue is reproduced by changing tabs. And also a second new window of the signer sometimes pops up.

Desktop-screenshot - 2022-10-10T184432 814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux
Projects
None yet
Development

No branches or pull requests

4 participants