Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] cluster config #4

Open
GopherJ opened this issue Aug 7, 2020 · 4 comments
Open

[feature request] cluster config #4

GopherJ opened this issue Aug 7, 2020 · 4 comments

Comments

@GopherJ
Copy link
Member

GopherJ commented Aug 7, 2020

currently it's not clear how one node discover the others after initialisation a raft node.

We need a cluster config to be shared across nodes.

@GopherJ
Copy link
Member Author

GopherJ commented Aug 7, 2020

Something like: https://github.com/oronsh/raftor/blob/master/Config.toml

Every node needs to claim it's ip during the initialisation so we can check in code if it's discover_node or not.

If not, then this node should send join request to the discover node

@PsiACE
Copy link
Contributor

PsiACE commented Aug 14, 2020

First of all, I have to admit that it is currently a library, not a server + client. Therefore, I plan to replace the operations on Enforcer with abstract traits, and in the end it may look like toshi-raft. Maybe later today, you can see this change in the branch named pure-lib.

So there will be no cluster config for the time being, that is what casbin-server needs to consider, maybe it will be further implemented in the next stage.

@GopherJ
Copy link
Member Author

GopherJ commented Aug 14, 2020

@PsiACE It can be put into casbin-server, it depends on how you design things, at the beginning I consider casbin-raft as casbin-server which provides everything out of box, but you can also make them into two libs, the importance is to be able to use it without any pain

@PsiACE
Copy link
Contributor

PsiACE commented Aug 14, 2020

Currently refer to toshi, especially toshi-types, to separate Casbin-Raft and Casbin-OPs. The code is in the pure-lib branch and still needs improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants