Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http fails to unpack certain tar.gz files #285

Closed
reegnz opened this issue Aug 10, 2023 · 3 comments · Fixed by #280
Closed

http fails to unpack certain tar.gz files #285

reegnz opened this issue Aug 10, 2023 · 3 comments · Fixed by #280
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed

Comments

@reegnz
Copy link
Contributor

reegnz commented Aug 10, 2023

What steps did you take:

I wanted to vendor a tar.gz file fetched from github:

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: sponnet
  contents:
  - path: .
    http:
      url: https://github.com/spinnaker/sponnet/archive/refs/tags/v1.26.0.tar.gz
      unpackArchive: true

What happened:
The tar.gz file was not unpacked.

What did you expect:
The tar.gz file should have been unpacked.

Anything else you would like to add:
Originally I experimented with a fix for the issue mentioned in #150.

Environment:

❯ vendir version
vendir version 0.34.3

Succeeded

OS: MacOS Ventura 13.5


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@reegnz reegnz added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Aug 10, 2023
@reegnz
Copy link
Contributor Author

reegnz commented Aug 10, 2023

Opened this issue because I was asked to by @praveenrewar in #150 (comment)

@github-actions
Copy link

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

@github-actions github-actions bot added the stale This issue has had no activity for a while and will be closed soon label Sep 20, 2023
@reegnz
Copy link
Contributor Author

reegnz commented Sep 20, 2023

There is an open PR already for this issue, #280 but tests still needs to be extended.

@joaopapereira joaopapereira added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity stale This issue has had no activity for a while and will be closed soon labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants