Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add option for skipping SSL verification when using Git #1286

Closed
joaopapereira opened this issue Aug 8, 2023 · 2 comments
Closed

Feature request: add option for skipping SSL verification when using Git #1286

joaopapereira opened this issue Aug 8, 2023 · 2 comments
Assignees
@sethiyash
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@joaopapereira
Copy link
Member

Describe the problem/challenge you have
Similar to carvel-dev/vendir#260, we need to allow the users of kapp-controller to use this new behavior in vendir.

Describe the solution you'd like
kapp-controller today as the flag dangerousSkipTLSVerify, but currently, we are not providing this flag to vendir when fetching from a git repository. We should enable this.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Vote on this request.

This invites the community to vote on issues to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible."
👎 "There are other more important things to focus on right now."

We are also happy to receive and review Pull Requests if you want to help work on this issue.
@joaopapereira joaopapereira added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels Aug 8, 2023
@renuy renuy added carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon. and removed carvel-triage This issue has not yet been reviewed for validity labels Aug 22, 2023
@basit9958
Copy link

/assign

@renuy renuy assigned sethiyash and unassigned basit9958 Nov 24, 2023
@sethiyash sethiyash mentioned this issue Dec 13, 2023
Merged
5 tasks
@joaopapereira
Copy link
Member Author

Closing this issues since PR #1419 was merged in December

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethiyash sethiyash

Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
Carvel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@renuy @joaopapereira @sethiyash @basit9958