Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): Fix Schema postgres ssl mode handling #591

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(db): Fix Schema postgres ssl mode handling #591

merged 1 commit into from
Sep 5, 2024

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented Sep 3, 2024

No description provided.

@fmoura fmoura added this to the 2.0.0 milestone Sep 3, 2024
@fmoura fmoura self-assigned this Sep 3, 2024
@fmoura fmoura requested a review from a team September 3, 2024 01:36
vfusco
vfusco requested changes Sep 3, 2024
View reviewed changes
internal/node/startup/startup.go Outdated Show resolved Hide resolved
GMKrieger
GMKrieger previously approved these changes Sep 4, 2024
View reviewed changes
@fmoura fmoura force-pushed the fix/fix-schema-postgres-ssl-mode branch from ae3c57f to 9ed2da3 Compare September 4, 2024 19:12
@fmoura fmoura force-pushed the fix/fix-schema-postgres-ssl-mode branch from 056b565 to c72e09c Compare September 4, 2024 19:46
GMKrieger
GMKrieger approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because it's working and we need to get things moving, but for 2.0 proper we need to have a discussion about config pattern on the Node because getting the not value of something is going to cause headaches in the future.

@fmoura fmoura force-pushed the fix/fix-schema-postgres-ssl-mode branch from c72e09c to 2206a7f Compare September 5, 2024 20:36
@fmoura fmoura merged commit 2206a7f into next/2.0 Sep 5, 2024
7 checks passed
@fmoura fmoura deleted the fix/fix-schema-postgres-ssl-mode branch September 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renan061 renan061 renan061 left review comments

@vfusco vfusco vfusco approved these changes

@marcelstanley marcelstanley marcelstanley approved these changes

@GMKrieger GMKrieger GMKrieger approved these changes

Assignees

@fmoura fmoura

Labels
None yet
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fmoura @vfusco @renan061 @marcelstanley @GMKrieger