Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/evm reader claim status #587

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented Aug 30, 2024

No description provided.

@fmoura fmoura added this to the 2.0.0 milestone Aug 30, 2024
@fmoura fmoura self-assigned this Aug 30, 2024
@fmoura fmoura changed the base branch from main to next/2.0 August 30, 2024 14:23
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch 4 times, most recently from 47de075 to f17dd2a Compare September 3, 2024 02:02
@fmoura fmoura marked this pull request as ready for review September 3, 2024 14:07
@fmoura fmoura marked this pull request as draft September 3, 2024 14:08
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from f17dd2a to 851b817 Compare September 3, 2024 14:39
@fmoura fmoura marked this pull request as ready for review September 3, 2024 14:39
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from 851b817 to 25d491b Compare September 3, 2024 14:49
@marcelstanley marcelstanley requested a review from a team September 3, 2024 19:41
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from 25d491b to e37c2e3 Compare September 3, 2024 22:55
internal/evmreader/evmreader.go Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/repository/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from ecfa50d to e9b70be Compare September 5, 2024 08:08
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor formatting details. Also, you need to squash the fixups

internal/evmreader/input.go Outdated Show resolved Hide resolved
internal/repository/evmreader.go Outdated Show resolved Hide resolved
internal/repository/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Show resolved Hide resolved
internal/evmreader/claim.go Show resolved Hide resolved
internal/evmreader/claim.go Show resolved Hide resolved
internal/evmreader/claim.go Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@marcelstanley marcelstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, split the changes into separate commits, specially because of the refactoring you did, @fmoura

internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/evmreader.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
internal/evmreader/claim.go Outdated Show resolved Hide resolved
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from 0e09f60 to a70988a Compare September 7, 2024 00:41
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from a70988a to 00e7450 Compare September 9, 2024 17:25
@fmoura fmoura force-pushed the feature/evm-reader-claim-status branch from 00e7450 to 43932d3 Compare September 9, 2024 23:14
@vfusco vfusco dismissed marcelstanley’s stale review September 12, 2024 15:05

Code will be merged on temporary branch next/2.0 and refactored.

Copy link
Collaborator

@vfusco vfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is with the intent of fixing the implementation later

@vfusco vfusco merged commit 43932d3 into next/2.0 Sep 12, 2024
7 checks passed
@vfusco vfusco deleted the feature/evm-reader-claim-status branch September 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants