Add reader mode and revert unnecessary changes to sunodo validator mode #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelstanley
force-pushed
the
fix/reader_mode_must_consider_experimental_mode
branch
from
71a744f
to
213c6b0
Compare
marcelstanley
force-pushed
the
fix/reader_mode_must_consider_experimental_mode
branch
from
213c6b0
to
c80b6bf
Compare
vfusco
previously approved these changes
Aug 16, 2024
renan061
previously approved these changes
Aug 16, 2024
marcelstanley
force-pushed
the
fix/reader_mode_must_consider_experimental_mode
branch
from
c80b6bf
to
032569f
Compare
This fixes an issue where the advance-runner was being set to run in reader mode whenever the claimer was disabled.
marcelstanley
force-pushed
the
fix/reader_mode_must_consider_experimental_mode
branch
2 times, most recently
from
7a4b699
to
c354f48
Compare
Reverts change that forced the claimer to be disabled when the sunodo validator mode is enabled. Both configurations must be set separately as usual.
For no obvious reason, the sunodo validator mode was been evaluated
marcelstanley
force-pushed
the
fix/reader_mode_must_consider_experimental_mode
branch
from
c354f48
to
ac1044b
Compare
renan061
approved these changes
Aug 16, 2024
vfusco
approved these changes
Aug 16, 2024
marcelstanley
deleted the
fix/reader_mode_must_consider_experimental_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts some of the changes made at #559 and add a sort of reader mode to better split the configuration in the case of the sunodo validator mode.