Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port mine command to 1.x #532

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Port mine command to 1.x #532

merged 2 commits into from
Jul 22, 2024

Conversation

marcelstanley
Copy link
Collaborator

@marcelstanley marcelstanley commented Jul 22, 2024

  • Cherry-picks command and devnet changes made at c719311 for next/2.0.
  • Also extends the command to allow for mining multiple blocks at a time.

As the cli is solely used for devnet, it assumes the provider is foundry/anvil in order to perform that instead of relying on method rpc_modules to discover if amvil_mine can be used instead of a loop of evm_mine calls to achieve the same result.

fmoura and others added 2 commits July 20, 2024 16:52
@marcelstanley marcelstanley requested review from fmoura and a team July 22, 2024 12:44
@marcelstanley marcelstanley self-assigned this Jul 22, 2024
@marcelstanley marcelstanley added the no changelog PRs that don't require changes in changelog label Jul 22, 2024
@marcelstanley marcelstanley requested a review from a team July 22, 2024 17:06
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question for a possible future issue: since this is the new way to advance the blockchain state, does it make sense to still have the increasetime command? Should we delete it?

@marcelstanley
Copy link
Collaborator Author

LGTM, just one question for a possible future issue: since this is the new way to advance the blockchain state, does it make sense to still have the increasetime command? Should we delete it?

You're right, this should be revisited later on.

@marcelstanley marcelstanley merged commit 2abb53c into main Jul 22, 2024
6 of 7 checks passed
@marcelstanley marcelstanley deleted the chore/port-mine-to-1.x branch July 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs that don't require changes in changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants