Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dead code #282

Merged
merged 1 commit into from
Jan 29, 2024
Merged

refactor: remove dead code #282

merged 1 commit into from
Jan 29, 2024

Conversation

gligneul
Copy link
Contributor

The dispatcher doesn't use the history foldable because this code was reimplemented in the authority-claimer service.

@gligneul gligneul added ! High priority #feat:dispatcher Feature: dispatcher labels Jan 24, 2024
@gligneul gligneul added this to the 1.3.0 milestone Jan 24, 2024
@gligneul gligneul self-assigned this Jan 24, 2024
@gligneul gligneul added the no changelog PRs that don't require changes in changelog label Jan 24, 2024
@GCdePaula
Copy link
Contributor

This works, but you can also just change the "root" foldable from RollupState to InputBox. (Then, if you want, you could delete RollupsState and History.)

The RollupsState is just this aggregate foldable. I recommend not using it, and instead setting the InputBox as your foldable.

How can I help you? I can do it if you prefer.

@gligneul gligneul linked an issue Jan 24, 2024 that may be closed by this pull request
Remove Claims Foldables #269
Closed
GCdePaula
GCdePaula approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

offchain/dispatcher/src/dispatcher.rs Show resolved Hide resolved
@gligneul
refactor: remove dead code
1b3cef6 
The dispatcher doesn't use the history foldable because this code was
reimplemented in the authority-claimer service.
@gligneul gligneul merged commit e5adb9f into main Jan 29, 2024
6 checks passed
@gligneul gligneul deleted the fix/input-reading branch January 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCdePaula GCdePaula GCdePaula approved these changes

@renan061 renan061 Awaiting requested review from renan061

Assignees

@gligneul gligneul

Labels
! High priority #feat:dispatcher Feature: dispatcher no changelog PRs that don't require changes in changelog
Projects
Node Unit
Status: ✅ Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Remove Claims Foldables
2 participants
@gligneul @GCdePaula