chore: add set -e for RUN heredoc instruction #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endersonmaia
force-pushed
the
chore/add-set-e-heredoc-run
branch
from
9458649
to
c47da64
Compare
When replacing RUN apt update && apt install ... we were making use of &&, that ensures that the following command will only execute if the previous one succeeds. When using the RUN <<EOF format, we lose this and can have some susprises during the docker build process. It's common for a command inside an RUN heredoc type to have a filing process but that whole instruction pass as a success in the build, and the result will only be noticed on the runtime image. Adding set -e will ensure that if any command fails, the whole instruction will fail.
endersonmaia
force-pushed
the
chore/add-set-e-heredoc-run
branch
from
c47da64
to
e82bf1d
Compare
gligneul
approved these changes
Jan 24, 2024
|
Nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing RUN apt update && apt install ... we were making use of &&, that ensures that the following command will only execute if the previous one succeeds. When using the RUN <<EOF format, we lose this and can have some surprises uring the docker build process. It's common for a command inside an RUN heredoc type to have a filing process but that whole instruction pass as a success in the build, and the result will only be noticed on the runtime image.
Adding set -e will ensure that if any command fails, the whole instruction will fail.
See: https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html