Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint markdown files on CI #275

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Lint markdown files on CI #275

merged 3 commits into from
Jan 23, 2024

Conversation

marcelstanley
Copy link
Collaborator

@marcelstanley marcelstanley commented Jan 22, 2024 •
edited
Loading

Closes #268

@marcelstanley marcelstanley self-assigned this Jan 22, 2024
@marcelstanley marcelstanley added the no changelog PRs that don't require changes in changelog label Jan 22, 2024
@marcelstanley marcelstanley force-pushed the feature/lint-md-on-ci branch 7 times, most recently from d80490a to cb7c53d Compare January 22, 2024 21:19
@marcelstanley marcelstanley requested review from a team, torives and GMKrieger January 22, 2024 21:20
@marcelstanley marcelstanley marked this pull request as ready for review January 22, 2024 21:27
@marcelstanley marcelstanley requested review from gligneul and removed request for a team January 22, 2024 21:27
gligneul
gligneul reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you add an entry to the Makefile as well? Something like make md-lint.

@marcelstanley
Copy link
Collaborator Author

Looks great! Could you add an entry to the Makefile as well? Something like make md-lint.

Sure, I completely forgot it! 😅

gligneul
gligneul suggested changes Jan 23, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
gligneul
gligneul approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gligneul gligneul merged commit 5ae0b87 into main Jan 23, 2024
4 checks passed
@gligneul gligneul deleted the feature/lint-md-on-ci branch January 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@torives torives Awaiting requested review from torives

@GMKrieger GMKrieger Awaiting requested review from GMKrieger

Assignees

@marcelstanley marcelstanley

Labels
no changelog PRs that don't require changes in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint Documentation MD files on CI
2 participants
@marcelstanley @gligneul