refactor: Docker build system #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gligneul
commented
Jan 17, 2024
•
gligneul
commented
- Refactored the Dockerfile, adding comprehensive documentation.
- Moved the version config to the bake file.
- Added the rollups-node prefix to all Docker images.
- Changed the installation dir of the binaries to /usr/bin.
- Changed the base Docker image to debian-bookworm instead cartesi/server-manager.
gligneul
force-pushed
the
feature/refactor-dockerfile
branch
from
57d77fb
to
67f8084
Compare
endersonmaia
requested changes
Jan 18, 2024
torives
reviewed
Jan 18, 2024
The Rust build is very slow. Adding this hash breaks the Docker cache and requires the build to always run.
gligneul
force-pushed
the
feature/refactor-dockerfile
branch
2 times, most recently
from
21c2b8b
to
1b763be
Compare
endersonmaia
requested changes
Jan 19, 2024
gligneul
force-pushed
the
feature/refactor-dockerfile
branch
from
13c969a
to
c11d374
Compare
- Refactored the Dockerfile, adding comprehensive documentation. - Moved the version config to the bake file. - Added the rollups-node prefix to all Docker images. - Changed the installation dir of the binaries to /usr/bin. - Changed the base Docker image to debian-bookworm instead cartesi/server-manager.
gligneul
force-pushed
the
feature/refactor-dockerfile
branch
from
c11d374
to
ec756c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.