Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use goroutines to start services #104

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Use goroutines to start services #104

merged 1 commit into from
Oct 2, 2023

Conversation

torives
Copy link
Contributor

@torives torives commented Sep 28, 2023

Closes #96

@torives torives requested a review from a team September 28, 2023 13:11
@torives torives self-assigned this Sep 28, 2023
@torives torives added the no changelog PRs that don't require changes in changelog label Sep 28, 2023
gligneul
gligneul reviewed Sep 28, 2023
View reviewed changes
cmd/cartesi-node/root.go Outdated Show resolved Hide resolved
gligneul
gligneul suggested changes Sep 28, 2023
View reviewed changes
internal/pkg/services/service.go Show resolved Hide resolved
internal/pkg/services/service.go Show resolved Hide resolved
cmd/cartesi-node/validator.go Outdated Show resolved Hide resolved
internal/pkg/services/graphql-service.go Outdated Show resolved Hide resolved
cmd/cartesi-node/validator.go Outdated Show resolved Hide resolved
cmd/cartesi-node/root.go Outdated Show resolved Hide resolved
internal/pkg/services/graphql-service.go Outdated Show resolved Hide resolved
gligneul
gligneul reviewed Sep 28, 2023
View reviewed changes
cmd/cartesi-node/root.go Outdated Show resolved Hide resolved
gligneul
gligneul previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@torives torives changed the base branch from main to next September 28, 2023 19:16
@torives torives dismissed gligneul’s stale review September 28, 2023 19:16

The base branch was changed.

@torives torives merged commit 7bd9d75 into next Oct 2, 2023
6 checks passed
@torives torives deleted the feat/goroutines branch October 2, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@renan061 renan061 renan061 approved these changes

Assignees

@torives torives

Labels
no changelog PRs that don't require changes in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run services using goroutines
3 participants
@torives @renan061 @gligneul