feat(database)!: simplify postgres config #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
force-pushed
the
feature/postgres-config
branch
from
49b7e7c
to
6e86575
Compare
torives
previously approved these changes
Sep 27, 2023
gligneul
force-pushed
the
feature/postgres-config
branch
from
3dba8a7
to
979b514
Compare
Receive a single environment variable to setup the postgres connection. It is now possible to omit the password and let the Pg drive load it from its own passfile.
gligneul
force-pushed
the
feature/postgres-config
branch
from
979b514
to
a3c95f3
Compare
torives
approved these changes
Sep 28, 2023
| @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Standardized log libraries and configuration | |||
| - Moved GraphQL schema generation to the CI. Now it is distributed as a Github artifact | |||
| - Replace `POSTGRES_*` environment variables with `POSTGRES_ENDPOINT` | |||
There was a problem hiding this comment.
Since there are plans to support sqlite, maybe we could already start naming this DATABASE_ENDPOINT or DATABASE_URL.
There was a problem hiding this comment.
I think this would fit perfectly in a separate ticket.
marcelstanley
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receive a single environment variable to setup the postgres connection. It is now possible to omit the password and let the Pg driver load it from its own passfile.
Close #55