From e82bf1db9d704348a92cecdbcec17931c9895471 Mon Sep 17 00:00:00 2001
From: Enderson Maia <endersonmaia@gmail.com>
Date: Wed, 24 Jan 2024 16:14:51 +0000
Subject: [PATCH] chore: add set -e for RUN heredoc instruction

When replacing RUN apt update && apt install ... we were making use of
&&, that ensures that the following command will only execute if the
previous one succeeds. When using the RUN <<EOF format, we lose this and
can have some susprises during the docker build process. It's common for
a command inside an RUN heredoc type to have a filing process but that
whole instruction pass as a success in the build, and the result will
only be noticed on the runtime image.

Adding set -e will ensure that if any command fails, the whole
instruction will fail.
---
 build/Dockerfile | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/build/Dockerfile b/build/Dockerfile
index ae68bdfe2..9c0ec2759 100644
--- a/build/Dockerfile
+++ b/build/Dockerfile
@@ -40,6 +40,7 @@ FROM ${BASE_IMAGE} as emulator-base
 # Install machine-emulator
 ARG MACHINE_EMULATOR_VERSION
 RUN <<EOF
+set -e
 apt-get update
 apt-get install -y --no-install-recommends \
     ca-certificates \
@@ -53,6 +54,7 @@ EOF
 
 # Configure cartesi user and group.
 RUN <<EOF
+set -e
 addgroup --system --gid 102 cartesi
 adduser --system --uid 102 \
     --disabled-login \
@@ -125,6 +127,7 @@ FROM ${BASE_IMAGE} as devnet-base
 # Install system dependencies.
 ARG DEBIAN_FRONTEND=noninteractive
 RUN <<EOF
+set -e
 apt-get update
 apt-get install -y --no-install-recommends \
     ca-certificates \
@@ -140,6 +143,7 @@ RUN curl -L https://foundry.paradigm.xyz | bash
 ENV PATH="~/.foundry/bin:${PATH}"
 ARG FOUNDRY_COMMIT_VERSION
 RUN <<EOF
+set -e
 bash -c foundryup -C ${FOUNDRY_COMMIT_VERSION}
 ln -s ~/.foundry/bin/anvil /usr/bin/anvil
 EOF
@@ -192,6 +196,7 @@ FROM rust:${RUST_VERSION}-bookworm AS rust-chef
 ARG RUST_BUILD_PATH
 WORKDIR ${RUST_BUILD_PATH}
 RUN <<EOF
+set -e
 rustup component add rustfmt
 cargo install cargo-chef
 EOF
@@ -212,6 +217,7 @@ FROM rust-chef as rust-builder
 # Install system dependencies.
 ARG DEBIAN_FRONTEND=noninteractive
 RUN <<EOF
+set -e
 apt-get update
 apt-get install -y --no-install-recommends \
     cmake \
@@ -258,6 +264,7 @@ FROM emulator-base as rollups-node
 # Download system dependencies required in runtime.
 ARG DEBIAN_FRONTEND=noninteractive
 RUN <<EOF
+set -e
 apt-get update
 apt-get install -y --no-install-recommends \
     ca-certificates \