Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped return type for getUserId in order to support UUIDs #529

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

Milannv
Copy link

@Milannv Milannv commented Apr 5, 2020

I came across this issue because I setup a custom model to serve as user model and by using UUIDs instead of numeric IDs.

The user model extends Cartalyst\Sentinel\Users\EloquentUser. The implemented interface, Cartalyst\Sentinel\Users\UserInterface, defines a return type.

This method can't be overridden by extending this interface. Using my custom model and creating an interface of my own (obviously) results in Sentinel becoming unusable because it expects the user model to be of type Cartalyst\Sentinel\Users\UserInterface.

@brunogaspar
Copy link
Member

Hi @Milannv

While it's a bugfix for your use case, i don't think we can do this change on v4, this is a breaking change unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants