Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/chapter1 #268

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/chapter1 #268

wants to merge 4 commits into from

Conversation

frinfo702
Copy link

This pull request includes significant changes to the chapter_01/p01_is_unique.py file, focusing on simplifying the codebase by removing redundant functions and updating function signatures. The most important changes are:

Refactoring and simplification:

  • Updated function signatures to use type hints and renamed parameters for consistency (string to s).
  • Removed redundant functions: is_unique_chars_using_dictionary, is_unique_chars_using_set, is_unique_chars_sorting, and is_unique_chars_sort.

Testing adjustments:

  • Commented out the removed functions from the test cases in the Test class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frinfo702