Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CreateFullPage): breadcrumbs should be array #6058

Merged

Conversation

wkeese
Copy link
Contributor

@wkeese wkeese commented Sep 16, 2024

Closes #5707.

Fix type of CreateFullPage.breadcrumbs

What did you change?

Made it an array rather than a single breadcrumb.

How did you test and verify your work?

Tested locally.

@wkeese wkeese requested a review from a team as a code owner September 16, 2024 06:15
@wkeese wkeese requested review from elycheea and amal-k-joy and removed request for a team September 16, 2024 06:15
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 413058b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66e7cd12422d0d000804bad8
😎 Deploy Preview https://deploy-preview-6058--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thanks @wkeese for the contribution

@elycheea elycheea added this pull request to the merge queue Sep 23, 2024
Merged via the queue into carbon-design-system:main with commit f076047 Sep 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CreateFullPage]: breadcrumbs prop is not typed as array in Typescript
3 participants