fix(DataGrid): disable save button on customise column #6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amal-k-joy
requested review from
elycheea and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidmenendez
requested changes
Sep 17, 2024
...oducts/src/components/Datagrid/Datagrid/addons/CustomizeColumns/CustomizeColumnsTearsheet.js
Outdated
Show resolved
Hide resolved
...oducts/src/components/Datagrid/Datagrid/addons/CustomizeColumns/CustomizeColumnsTearsheet.js
Outdated
Show resolved
Hide resolved
davidmenendez
requested changes
Sep 18, 2024
davidmenendez
approved these changes
Sep 19, 2024
elycheea
reviewed
Sep 23, 2024
| @@ -1981,6 +1984,41 @@ describe(componentName, () => { | |||
| ); | |||
| }); | |||
| }); | |||
| it('Customizing Columns disable save button when un-select all columns', async () => { | |||
There was a problem hiding this comment.
Not necessarily for this PR, but it could be good to take a look at our conventions and naming for the base component and extensions. Could be good to come up with some better organization for the extensions themselves.
elycheea
approved these changes
Sep 23, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 23, 2024
2b32f0f
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5843
If all the columns are unchecked, Save button should not be enabled in Datagrid customise columns
How did you test and verify your work?
storybook