fix(datagrid): use same empty array every time #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [] !== [], need to be careful when setting [] as a default value and then using it in the dependencies of useEffect() etc. Fixes carbon-design-system#5998.
wkeese
requested review from
matthewgallo and
devadula-nandan
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Thanks for contributing this @wkeese! We just saw something similar in a different component that was moving from defaultProps to default function params.
Merged
via the queue into
carbon-design-system:main
with commit Sep 4, 2024
e6ce08b
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5998
Since [] !== [], need to be careful when setting [] as a default value and then using it in the dependencies of useEffect() etc.
What did you change?
Created constant variables so that filters, reactTableFiltersState, etc. variables get the same default value every time.
How did you test and verify your work?
Storybook