Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): hidden columns included in search results #5989

Conversation

sangeethababu9223
Copy link
Member

Closes #5509

Hidden columns are included in search results.

What did you change?

packages/ibm-products/src/components/Datagrid/Extensions/ColumnCustomization/ColumnCustomization.stories.jsx
Updated columns prop to include disableGlobalFilter: true for hidden columns in story.

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit b708b05
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66f242bd4c0a5f000833e7a9
😎 Deploy Preview https://deploy-preview-5989--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review September 5, 2024 07:36
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner September 5, 2024 07:36
@sangeethababu9223 sangeethababu9223 requested review from makafsal and AlexanderMelox and removed request for a team September 5, 2024 07:36
Copy link
Contributor

@AlexanderMelox AlexanderMelox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we talked previously this week, there might be a better way to do this

@sangeethababu9223
Copy link
Member Author

Like we talked previously this week, there might be a better way to do this

Hey @AlexanderMelox ,
I did some research following our meeting, and the only alternative I could find was writing a custom filter function. I also found a similar discussion topic in the React Table repository, but it doesn’t have a solution yet. There might be a better approach in TanStack version 8—I can look into this further if needed for a future implementation. This workaround is the best I could find at the moment.

However if I've missed something please let me know.

@AlexanderMelox
Copy link
Contributor

Okay I went through it, I believe the only thing @matthewgallo mentioned was using await wait(0) instead of setTimeout, but i would double check with him

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make a note about this being an area where the changes in @tanstack/react-table v8 make this functionality much easier to implement.

Merged via the queue into carbon-design-system:main with commit 189f452 Sep 24, 2024
21 checks passed
@sangeethababu9223 sangeethababu9223 deleted the fix/datagrid-hidden-columns-in-search-results branch September 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datagrid]: Hidden columns are included in search results.
3 participants