-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): hidden columns included in search results #5989
fix(datagrid): hidden columns included in search results #5989
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…-columns-in-search-results
…://github.com/sangeethababu9223/ibm-products into fix/datagrid-hidden-columns-in-search-results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we talked previously this week, there might be a better way to do this
Hey @AlexanderMelox , However if I've missed something please let me know. |
Okay I went through it, I believe the only thing @matthewgallo mentioned was using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make a note about this being an area where the changes in @tanstack/react-table
v8 make this functionality much easier to implement.
189f452
Closes #5509
Hidden columns are included in search results.
What did you change?
packages/ibm-products/src/components/Datagrid/Extensions/ColumnCustomization/ColumnCustomization.stories.jsx
Updated
columns
prop to includedisableGlobalFilter: true
for hidden columns in story.How did you test and verify your work?
Storybook