feat: add customSvg prop to FullPageError
#5976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-cooper
requested review from
AlexanderMelox and
anamikaanu96
and removed request for
a team
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stefan-cooper
force-pushed
the
5975-customsvg
branch
2 times, most recently
from
4cb6af3
to
ec34195
Compare
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
stefan-cooper
force-pushed
the
5975-customsvg
branch
from
ec34195
to
fb4a8a1
Compare
Signed-off-by: Stefan Cooper <[email protected]>
stefan-cooper
force-pushed
the
5975-customsvg
branch
from
fb4a8a1
to
d090c41
Compare
|
waiting for issue triaging/design opinion as a first pass. |
AlexanderMelox
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Looks good to me, like @devadula-nandan said lets see what design says
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5975
This PR adds a new optional prop to the
FullPageErrorcomponent. It allows you to provide a custom JSX/svg instead of the generic svg for 'custom' full page errorsWhat did you change?
I added a new optional property that is used when
kindiscustomandcustomSvgis defined. Otherwise, it will use the original behavior.How did you test and verify your work?
I added a test that uses the 403 svg on the 'custom' kind and verified that it was found.