fix: tearsheet with nav accessibility #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmenendez
requested review from
makafsal and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
davidmenendez
dismissed stale reviews from makafsal and amal-k-joy
via
a6bf660
amal-k-joy
approved these changes
Sep 5, 2024
makafsal
approved these changes
Sep 5, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 5, 2024
d2aeeb2
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4989
this updates
Tearsheetstories to demonstrate proper nav implementation using carbonTabs. the solution is to just wrap the entire thing in aTabscomponent.this also demonstrates a fairly more straight forward implementation approach that doesn't rely on an array like in the
PageHeaderstory implementation and just uses a react element.confirmed locally that this implementation addresses the accessibility concerns