fix: update toHaveNoAxeViolations and remove skips

[lee-chase]

Updates toHaveNoAxeViolations and fixes a small number of use cases.

What did you change?

The function was creating a new Promise which is not necessary, refactored.

Not entirely sure the async/await is doing much in the tests that were refactored, but with async tests the accessible checks need to be waited for when there are multiple uses of the accessible matchers.

How did you test and verify your work?

Ran the tests.

[netlify]

✅ Deploy Preview for carbon-for-ibm-products ready!

Name	Link
🔨 Latest commit	4b4292a
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66cdf28ac17f5e0008eae994
😎 Deploy Preview	https://deploy-preview-5955--carbon-for-ibm-products.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[amal-k-joy]

LGTM

@elycheea , @lee-chase
Looks like we have not added await in most of our accessibility test cases across components (eg: AboutModal.test, AddSelect.test ...)
Do we need to create an new issue to add await ?

 it('has no accessibility violations', async () => {
    const { container } = render(<AddSelect {...defaultProps} />);
    expect(container).toBeAccessible(componentName);
    expect(container).toHaveNoAxeViolations();
  });

[lee-chase]

LGTM

@elycheea , @lee-chase Looks like we have not added await in most of our accessibility test cases across components (eg: AboutModal.test, AddSelect.test ...) Do we need to create an new issue to add await ?

 it('has no accessibility violations', async () => {
    const { container } = render(<AddSelect {...defaultProps} />);
    expect(container).toBeAccessible(componentName);
    expect(container).toHaveNoAxeViolations();
  });

@amal-k-joy it only seems to be needed if you want to run multiple accessibility tests from within the same module.

[elycheea]

Thank you for cleaning up those .skip()s! 🙏