fix(datagrid): customise column tearsheet update issue with new columns #5953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangeethababu9223
requested review from
matthewgallo and
anamikaanu96
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…column-update-issue
matthewgallo
approved these changes
Aug 28, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 28, 2024
7ab472a
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5482
Customize column tearsheet doesn't update with new columns
What did you change?
Added condition to check if
columnDefinitionsupdated inpackages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/CustomizeColumnsTearsheet.jsso that columns are updated accordinglyHow did you test and verify your work?
Storybook (Updated the story for
ColumnCustomizationto check the new column addition after initial render.)