-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pageheader): compensate the width of the overflow menu #5929
fix(pageheader): compensate the width of the overflow menu #5929
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Screen caps showing the fix Screen.Recording.2024-08-22.at.3.36.13.PM.movScreen.Recording.2024-08-22.at.3.37.07.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only concern would be the button size changing.
Can you see if you can send back a ref to the overflow menu from the |
Used a ref for dynamic width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're still using both TS types and prop types, can you update the the prop types for the components that now have new props?
Makes sense, added the proptypes |
can you check |
baf0ec2
Closes #5806
This PR fixes the issue of the overflow menu hiding actions even when there is enough space. I don't know if this is the best fix for it maybe @lee-chase can help out.
What did you change?
packages/ibm-products/src/components/PageHeader/PageHeader.tsx
How did you test and verify your work?
By opening the build and resizing the browser