-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Datagrid): remove filter tags individually from FilterSummary
#3582
Merged
matthewgallo
merged 7 commits into
carbon-design-system:main
from
matthewgallo:3402-datagrid-remove-filters-individually
Oct 17, 2023
Merged
feat(Datagrid): remove filter tags individually from FilterSummary
#3582
matthewgallo
merged 7 commits into
carbon-design-system:main
from
matthewgallo:3402-datagrid-remove-filters-individually
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ibm-products/src/components/Datagrid/Datagrid/addons/Filtering/hooks/useFilters.js
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/Datagrid/Datagrid/addons/Filtering/FilterProvider.js
Show resolved
Hide resolved
packages/ibm-products/src/components/Datagrid/Datagrid/addons/Filtering/FilterProvider.js
Outdated
Show resolved
Hide resolved
…m:matthewgallo/ibm-products into 3402-datagrid-remove-filters-individually
davidmenendez
approved these changes
Oct 16, 2023
As a follow up enhancement, the user won't be able to close filters if it's in the dropdown |
@matthewgallo Everything else looks great 🎉 🚀 Nice job on this! |
AlexanderMelox
approved these changes
Oct 17, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 17, 2023
ad74bc6
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3402
This PR adds functionality to remove individual filter tags from the filter summary component used in the Datagrid. This change works with both the flyout and panel variants.
What did you change?
How did you test and verify your work?
Storybook