Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Saving): reversed icons for default state (save) and success state (checkmark) #3571

Merged

Conversation

MriduMohan
Copy link
Contributor

Contributes to #2849

What did you change?

Reversed the the icons shown for default state and success state to save and checkmark icons respectively.

How did you test and verify your work?

storybook

@MriduMohan MriduMohan requested a review from a team as a code owner October 10, 2023 18:35
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1a13f25
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/652a891953eed200087a8d72
😎 Deploy Preview https://deploy-preview-3571--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@MriduMohan
Copy link
Contributor Author

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

MriduMohan seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.You can retrigger this bot by commenting recheck in this Pull Request

I have read the DCO document and I hereby sign the DCO.

@elycheea elycheea linked an issue Oct 10, 2023 that may be closed by this pull request
@elycheea
Copy link
Contributor

@MriduMohan Thanks for submitting your first PR with us! It looks like the email associated with your commit does not match the one on your GitHub account. I think the DCO should work once you add your IBM address to your public GitHub account! (Although you might still need to comment recheck again once you add it.)

@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck Oct 10, 2023
@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) Oct 10, 2023
@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck Oct 10, 2023
@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck Oct 11, 2023
@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck Oct 11, 2023
@MriduMohan MriduMohan changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) recheck fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) Oct 11, 2023
@MriduMohan
Copy link
Contributor Author

recheck

@MriduMohan
Copy link
Contributor Author

@elycheea , could you please tell me how to resolve the check. I tried the ways you told above. It still doesn't work.

@MriduMohan
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix!

Also caught a small alignment issue when testing this —

image

The loading icon is not vertically centered. We can open this as a separate bug but also would like to know if you’d like to include this since it’s noticeable here.

@MriduMohan
Copy link
Contributor Author

Thanks for contributing this fix!

Also caught a small alignment issue when testing this —

image The loading icon is not vertically centered. We can open this as a separate bug but also would like to know if you’d like to include this since it’s noticeable here.

Could this be raised as a separate issue, as this issue was existing before.

@elycheea elycheea changed the title fix(Pattern-Saving): Reversed the icons for default state (save) and success state(checkmark) fix(Saving): reversed icons for default state (save) and success state (checkmark) Oct 17, 2023
@elycheea elycheea added this pull request to the merge queue Oct 17, 2023
Merged via the queue into carbon-design-system:main with commit a5eadfb Oct 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse Saving pattern icons
2 participants