-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vertical alignment in larger row heights #3568
fix: vertical alignment in larger row heights #3568
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this @Tanush-J! There may be some missing styles, if you look at one of the stories for the Datagrid that includes selectable rows, you'll notice that the checkbox and the row content do not align.
You can use the Batch action story as an example to view this behavior.
Instead of changing verticalAlign
default value to top
, I think it would be better to do this by targeting the xl class, something like:
.cds--data-table--xl .c4p--datagrid__head,
.cds--data-table--xl .c4p--datagrid__carbon-row {
align-items: flex-start;
}
This could be added to _RowSizeDropdown.scss
, replacing cds--data-table
and c4p--datagrid
with the appropriate sass variables.
Ok I will look into this |
Yes, you're correct. There will be some more styling changes required given the different variations of this component. |
Hey @Tanush-J, we had to address this issue in a separate PR. We'd welcome future contributions! |
Contributes to #3548
After this content is top-aligned in
Extra large
row height.What did you change?
Changed the default value of
verticalAlign
property from'center'
to'top'
in DatagridContent.js file.How did you test and verify your work?
273671150-a47c90a3-628a-4beb-aee2-7c3a5ba80342.mp4