Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): expander title / aria-label updates #3564

Conversation

matthewgallo
Copy link
Member

Contributes to #3561

Properly assigns a more logical value to the row expander title and aria-label attributes, as opposed to using the default value that react-table provides via {...row.getToggleRowExpandedProps()}.

This change has been applied to both expanded and nested rows.

What did you change?

packages/ibm-products/src/components/Datagrid/Datagrid/DatagridExpandedRow.js
packages/ibm-products/src/components/Datagrid/Extensions/ExpandableRow/ExpandableRow.docs-page.js
packages/ibm-products/src/components/Datagrid/Extensions/ExpandableRow/ExpandableRow.stories.js
packages/ibm-products/src/components/Datagrid/Extensions/NestedRows/NestedRows.stories.js
packages/ibm-products/src/components/Datagrid/styles/_useExpandedRow.scss
packages/ibm-products/src/components/Datagrid/useNestedRowExpander.js
packages/ibm-products/src/components/Datagrid/useRowExpander.js
packages/ibm-products/src/components/Datagrid/utils/getArgTypes.js

How did you test and verify your work?

Storybook

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 2cb805d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6525506cad783200087752c7
😎 Deploy Preview https://deploy-preview-3564--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but looks like we need to update the tests with some of these changes.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, I suppose it was about time we started refactoring these tests a bit.

@elycheea elycheea added this pull request to the merge queue Oct 10, 2023
@matthewgallo
Copy link
Member Author

😅 Yes, plenty more to do but at least it's a start

Merged via the queue into carbon-design-system:main with commit 1bcff24 Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants