-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Datagrid): expander title / aria-label updates #3564
fix(Datagrid): expander title / aria-label updates #3564
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but looks like we need to update the tests with some of these changes.
…atthewgallo/ibm-products into 3561-expander-title-aria-label-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, I suppose it was about time we started refactoring these tests a bit.
😅 Yes, plenty more to do but at least it's a start |
1bcff24
Contributes to #3561
Properly assigns a more logical value to the row expander
title
andaria-label
attributes, as opposed to using the default value thatreact-table
provides via{...row.getToggleRowExpandedProps()}
.This change has been applied to both expanded and nested rows.
What did you change?
How did you test and verify your work?
Storybook