fix: datagrid empty state fixes #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
reviewed
Oct 3, 2023
| expect( | ||
| screen.getByRole('table').getElementsByTagName('tbody')[0].className | ||
| ).toEqual('c4p--datagrid__empty-state-body'); | ||
| document.querySelector(`.${pkg.prefix}--empty-state-type--noData`) |
There was a problem hiding this comment.
We should avoid document.querySelector if possible
There was a problem hiding this comment.
i'll take another look
|
@matthewgallo fixed the tests by adding a |
matthewgallo
approved these changes
Oct 3, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 3, 2023
9df5e1d
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3243
mostly just addresses some testing. to help facilitate testing I added specific class names to all the empty state variants, which honestly should have been done from the start haha
there was a point in the issue to mention how to set the error type, but i think there needs to be a bigger discussion about prop types and that documentation for datagrid. so i opted to skip it for now.