Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): add text overflow styling to title/desc #3426

Conversation

matthewgallo
Copy link
Member

Contributes to #3158

Adds some missing styles to allow for handling text overflow in the Datagrid title and descriptions.

What did you change?

packages/ibm-products/src/components/Datagrid/styles/_datagrid.scss

How did you test and verify your work?

Storybook, was able to use the controls in the Header Datagrid story to confirm the expected behavior

@matthewgallo matthewgallo requested a review from a team as a code owner August 29, 2023 17:57
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4cfa3bb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/64ee472a5f32e800084f57bb
😎 Deploy Preview https://deploy-preview-3426--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elycheea elycheea added this pull request to the merge queue Aug 29, 2023
Merged via the queue into carbon-design-system:main with commit 0034e0e Aug 29, 2023
13 of 15 checks passed
@matthewgallo matthewgallo deleted the 3158-datagrid-header-truncation branch August 30, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants