Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some full screen docs pages #3419

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

lee-chase
Copy link
Member

Some stories are poorly formatted or present badly on the docs page. This is because Storybook has changed the way in which the stories are hosted on the docs page.

We should as a result try to ensure

  • All stories reserve the space they need to present themselves (some stories have no content or only content that does not reserve vertical space.
  • Have the stories, not common CSS, specify the size of the viewport on the docs page.

e.g.
image

What did you change?

How did you test and verify your work?

Viewed in Storybook

@lee-chase lee-chase requested a review from a team as a code owner August 29, 2023 12:27
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 116e694
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/64ede420da585d0008a4ffd0
😎 Deploy Preview https://deploy-preview-3419--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some weird behavior with the entrance/exit of the side panels in the storybook docs preview. Do you think that is something related? I think we can open that as a new issue and have this PR address the layout issues that existed before.

@elycheea elycheea added this pull request to the merge queue Aug 29, 2023
Merged via the queue into carbon-design-system:main with commit 9a1faf9 Aug 29, 2023
12 of 14 checks passed
@lee-chase lee-chase deleted the docsPageFullScreen branch September 27, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants