Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: Export Modal Dialog closing on second esc keypress #6015

Closed
2 tasks done
devadula-nandan opened this issue Sep 6, 2024 · 1 comment
Closed
2 tasks done

[a11y]: Export Modal Dialog closing on second esc keypress #6015

devadula-nandan opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
component: modal For about, export, import, remove modals screen-reader: JAWS Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: a11y ♿ Issues not following accessibility standards type: bug 🐛 Something isn't working

Comments

@devadula-nandan
Copy link
Contributor

devadula-nandan commented Sep 6, 2024

Package

@carbon/ibm-products

Browser

Chrome, Firefox, Edge

Operating System

Windows

Package version

v2.49.0-rc.0

React version

No response

Automated testing tool and ruleset

manual

Assistive technology

JAWS

Description

Reported by Raghu during screen reader testing.
The "Export" dialog closes only after activating the esc key a second time.
As a best practice, the Modal is expected to close with a single press of Escape key.

WCAG 2.1 Violation

No response

Reproduction/example

https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-export-exportmodal--standard&globals=viewport:basic

Steps to reproduce

This was reported in all variants of the Export Modal by Raghu.

open the export modal in a windows machine with jaws activated, and press esc key and notice the modal doesn't close on first time

Code of Conduct

@devadula-nandan devadula-nandan added status: needs triage 🕵️‍♀️ type: a11y ♿ Issues not following accessibility standards type: bug 🐛 Something isn't working Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. screen-reader: JAWS component: modal For about, export, import, remove modals and removed status: needs triage 🕵️‍♀️ labels Sep 6, 2024
@davidmenendez davidmenendez self-assigned this Sep 23, 2024
@davidmenendez
Copy link
Contributor

i was unable to replicate this behavior in chrome or firefox. also the ExportModal code isn't doing anything with or capturing any keystrokes, so i don't believe anything specifically in this file would be causing this behavior. i think we can chalk this up to an isolated incident. if not this may indicate a bigger problem affecting the underlying Modal component. so in light of all that i'm going to close this issue. lets just keep an eye out for this issue as Raghu continues testing additional modal components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: modal For about, export, import, remove modals screen-reader: JAWS Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. type: a11y ♿ Issues not following accessibility standards type: bug 🐛 Something isn't working
Projects
Status: Done 🚀
Development

No branches or pull requests

2 participants