-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ActionSet to use container queries #4164
Comments
ActionSet is used in Tearsheet, CreateFullPage, FilterFlyout, FilterPanel, SidePanel. |
Maybe @cameroncalder @Laura-Marshall or @My-Money29 can help with reviewing this once in deploy preview. |
We have Action set used in a number of places. The following behavior is either a inconsistent or not achievable without DOM manipulation. DOM manipulation is problematic when using LIT to construct web components.
Use cases
|
@cameroncalder @Laura-Marshall @My-Money29 I'm thinking of making the buttons in all cases stack like the SidePanel version when narrow. Any objections before I jump into coding this? |
From what I can gather from this thread, having the buttons stack when things become small across the board makes sense to me. |
Should evaluate whether we can replace the ActionSet with ButtonSet. |
@elycheea what is status of this work? |
@ljcarot On hold. I believe @lee-chase did some exploration and prototyping for this work on the Core repo as well using |
Move all the behavior to the ActionSet and use container queries to update the layout. This will lead to a slight head scratcher in SidePanel where the width of the use of a 1px left border and box-sizing border box (hint the width of the ActionSet on a 2xl SidePanel is 2xl - 1.
Originally posted by @lee-chase in #4019 (comment)
The text was updated successfully, but these errors were encountered: