docs: updated content to reference IBM Design Language #355
Conversation
|
I updated the nav link. I also then updated the subtitle so that it didn't read the same. ...I couldn't think of a good title that would fit neatly into our nav formatting. Best I could come up with was "IBM Design Language". I would keep it internal until we can synchronize with https://w3.ibm.com/design/essentials so that the url doesn't read "carbon-and-duo", and then make it public. |
| @@ -2,7 +2,7 @@ | |||
| "getting-started": { | |||
| "title": "Getting Started", | |||
| "subnav": { | |||
| "carbon-and-duo": "Carbon and Duo", | |||
| "carbon-and-duo": "IBM Design Language", | |||
There was a problem hiding this comment.
Should we change the subnav title, as well? The "carbon-and-duo" bit.
There was a problem hiding this comment.
That's the actual url, we could probably add a redirect though until https://w3.ibm.com/design/essentials can update their link.
There was a problem hiding this comment.
If we want to do a redirect on our side then yes, we can just resolved everything and update our subnav to "design-language" or something similar.
There was a problem hiding this comment.
The title of the page is generated from the nav (I think) so we need to update everything all at once. Not sure on how to setup redirects with this version of the website so we should coordinate with the w3.ibm.com site on updating their url.
So still need to update, the nav, the folder name, the file names inside of pages and content.
There was a problem hiding this comment.
@shinytoyrobots can go ahead and update the title and nav link. Then we can submit a PR here to update the link on the design website https://github.ibm.com/Design/w3-design-site/blob/master/pages/design/essentials.js#L182
|
Hey @claycrenshaw we can't merge this in yet until the navigation issues are worked out. If you have edits go ahead and comment them here and @shinytoyrobots will update the PR. |
|
If it's helpful, can use the GitHub Review UI to make comments on certain lines 👍 https://help.github.com/articles/about-pull-request-reviews/ talks about it a bit |
I updated the content to remove references to Duo and for clarity.
NB: We should change the url, too...but will need to liaise with web team who built https://w3.ibm.com/design/essentials, as that links to /carbon-and-duo