Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combobx ref bug #16135

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Apr 4, 2024

Closes #14756

worked on this with @riddhybansal 🎉

  • Update the ability to pass in ref in ComboBox

Testing

  • Import ComboBox into a .tsx file and pass in the ref attribute - should no longer show an error as seen below
Screenshot 2024-04-04 at 09 20 03

bobox-ref-bug
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 6b50f83
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/660ec574dc1bc300082967f3
😎 Deploy Preview https://deploy-preview-16135--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreancardona andreancardona added this pull request to the merge queue Apr 4, 2024
Merged via the queue into carbon-design-system:main with commit dd07c6f Apr 4, 2024
20 checks passed
@andreancardona andreancardona deleted the 14756-fix-combobox-ref-bug branch April 4, 2024 17:35
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot pass ref to ComboBox after typings update
3 participants