Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keyboard Nav AVT test for MenuButton #14842

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add Keyboard Nav AVT test for MenuButton #14842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da48adb
test: added avt file
guidari Oct 9, 2023
d369ae8
test: added keyboard nav test
guidari Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 137 additions & 0 deletions e2e/components/MenuButton/MenuButton-test.avt.e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
/**
* Copyright IBM Corp. 2023
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const { expect, test } = require('@playwright/test');
const { visitStory } = require('../../test-utils/storybook');

test.describe('MenuButton @avt', () => {
test('@avt-default-state MenuButton', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--default',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('MenuButton');
});

test('@avt-advanced-states MenuButton with danger', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--with-danger',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('MenuButton-with-danger');
});

test('@avt-advanced-states MenuButton with dividers', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--with-dividers',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('MenuButton-with-dividers');
});

test('@avt-keyboard-nav MenuButton', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--default',
globals: {
theme: 'white',
},
});

const actionButton = page.getByRole('button', { name: 'Action' });
await expect(actionButton).toBeVisible();

await page.keyboard.press('Tab');
await expect(actionButton).toBeFocused();

// Entering the menu button
await page.keyboard.press('Enter');
await expect(page.getByRole('menuitem').first()).toBeFocused();
await page.keyboard.press('ArrowDown');
await expect(page.getByRole('menuitem').nth(1)).toBeFocused();
// Skip the disabled item and come back to the first item
await page.keyboard.press('ArrowDown');
await expect(page.getByRole('menuitem').first()).toBeFocused();

// Closing by selecting an item and focusing on the action button
await page.keyboard.press('Enter');
await expect(actionButton).toBeFocused();
});

test('@avt-keyboard-nav MenuButton with danger', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--with-danger',
globals: {
theme: 'white',
},
});

const actionButton = page.getByRole('button', { name: 'Action' });
await expect(actionButton).toBeVisible();

await page.keyboard.press('Tab');
await expect(actionButton).toBeFocused();

// Entering the menu button
await page.keyboard.press('Enter');
await expect(page.getByRole('menuitem').first()).toBeFocused();
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');

// Validate danger button
await expect(page.getByRole('menuitem').last()).toBeFocused();
await expect(page.getByText('Danger action')).toBeVisible();

// Closing by selecting an item and focusing on the action button
await page.keyboard.press('Enter');
await expect(actionButton).toBeFocused();
});

test('@avt-keyboard-nav MenuButton with dividers', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--with-dividers',
globals: {
theme: 'white',
},
});

const actionButton = page.getByRole('button', { name: 'Action' });
await expect(actionButton).toBeVisible();

await page.keyboard.press('Tab');
await expect(actionButton).toBeFocused();

// Entering the menu button
await page.keyboard.press('Enter');
await expect(page.getByRole('menuitem').first()).toBeFocused();
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await expect(page.getByRole('menuitem').last()).toBeFocused();
expect(page.getByRole('separator')).toBeTruthy();

// Closing by selecting an item and focusing on the action button
await page.keyboard.press('Enter');
await expect(actionButton).toBeFocused();
});
});
15 changes: 2 additions & 13 deletions e2e/components/MenuButton/MenuButton-test.e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

'use strict';

const { expect, test } = require('@playwright/test');
const { test } = require('@playwright/test');
const { themes } = require('../../test-utils/env');
const { snapshotStory, visitStory } = require('../../test-utils/storybook');
const { snapshotStory } = require('../../test-utils/storybook');

test.describe('MenuButton', () => {
themes.forEach((theme) => {
Expand All @@ -23,15 +23,4 @@ test.describe('MenuButton', () => {
});
});
});

test('accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'MenuButton',
id: 'components-menubutton--default',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('MenuButton');
});
});
Loading