Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Nav AVT test for MenuButton #14842

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 10, 2023

Closes #14800

Added keyboard navigation to MenuButton component.

Changelog

New

  • Added new file e2e/components/MenuButton/MenuButton-test.avt.e2e.js

Testing / Reviewing

  • Ensure the test pass.
  • Ensure that the expected navigation is covered.

@guidari guidari requested a review from a team as a code owner October 10, 2023 12:21
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d369ae8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/652541d62d1ecf000750612c
😎 Deploy Preview https://deploy-preview-14842--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d369ae8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/652541d6302f370008a01445
😎 Deploy Preview https://deploy-preview-14842--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2023
@guidari guidari added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 13, 2023
@guidari guidari added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 13, 2023
@guidari guidari added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 13, 2023
@guidari guidari added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 13, 2023
@guidari guidari added this pull request to the merge queue Oct 16, 2023
Merged via the queue into carbon-design-system:main with commit 95250c2 Oct 16, 2023
21 checks passed
@guidari guidari deleted the 14800-avt-menubutton branch October 16, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Nav AVT test for MenuButton
3 participants