-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keyboard Nav AVT test for MenuButton
#14842
Merged
guidari
merged 2 commits into
carbon-design-system:main
from
guidari:14800-avt-menubutton
Oct 16, 2023
Merged
Add Keyboard Nav AVT test for MenuButton
#14842
guidari
merged 2 commits into
carbon-design-system:main
from
guidari:14800-avt-menubutton
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Oct 10, 2023
alisonjoseph
approved these changes
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 13, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 16, 2023
95250c2
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14800
Added keyboard navigation to
MenuButton
component.Changelog
New
e2e/components/MenuButton/MenuButton-test.avt.e2e.js
Testing / Reviewing