Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency stylelint-prettier to v4 - abandoned #14744

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 2, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint-prettier ^2.0.0 -> ^4.0.0 age adoption passing confidence

Release Notes

prettier/stylelint-prettier (stylelint-prettier)

v4.0.2

Compare Source

Fix case where an error is thrown when no prettier configuration file is found (#​311)

v4.0.1

Compare Source

Fix prettier-plugin-svelte support by ensuring .svelte files are ignored. The regression of them not being ignored only affected v4.0.0. (#​309)

v4.0.0

Compare Source

Add support for Prettier v3.

In order to make Prettier v3 work, we've had to drop support for Prettier v2.x and Stylelint less that v15.8.0. Maintaining temporary support for Prettier v2 and v3 at the same time isn't worth the complication that results thanks to prettier's migration to es modules. When you update to prettier v3, ensure that you update stylelint-prettier at the same time.

  • Minimum supported prettier version is now v3.0.0.
  • Minimum supported stylelint version is now v15.8.0.

v3.0.0

Compare Source

Remove stylelint-config-prettier from the recommended config. Stylelint v15 deprecated the rules that stylelint-config-prettier disabled, thus if you do not use those deprecated rules then you do not need stylelint-config-prettier. If you are still using these deprecated rules then you should install and configure stylelint-config-prettier separately.

Increase the mimimum required node version. No code changes have been required and v2.0.0 works with stylelint v15, however continuing to test with the unsupported node 12 is a burden that is not worth carrying.

  • Minimum node requirement is now "^14.17.0 || >=16.0.0" (drop support for v12.x)
  • If you extended from the stylelint-prettier/recommended in v2 then you must add an explict extend from stylelint-config-prettier to retain the same behaviour.

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 2, 2023 03:40
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9d63b61
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/651b2597f091fc0008ab5403
😎 Deploy Preview https://deploy-preview-14744--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9d63b61
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/651b25972f3b0400082b0941
😎 Deploy Preview https://deploy-preview-14744--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@tw15egan
Copy link
Member

tw15egan commented Oct 2, 2023

I've been working on this PR and have updated prettier to v3 and stylelint to v15. Also went ahead and updated the plugins we use as well, and fixed the linting issues that arose due to the change.

@tw15egan tw15egan force-pushed the renovate/stylelint-prettier-4.x branch from 19b60f9 to 60ded6d Compare October 2, 2023 19:41
@tw15egan
Copy link
Member

tw15egan commented Oct 2, 2023

@tay1orjones tried taking a whack at this, but curious if we will run into issues having two versions of prettier in the codebase. I left some at 2.8.8 https://github.com/prettier/stylelint-prettier/blob/main/CHANGELOG.md#400-2023-07-07

Screenshot 2023-10-02 at 4 01 23 PM

@tay1orjones
Copy link
Member

@tw15egan Every package that's a workspace will need to be upgraded I think. Are there blockers to updating everything to prettier v3?

@tw15egan
Copy link
Member

Seems like test-utils is blocked until Jest 30 is released: jestjs/jest#14305. Getting some additional errors when trying to update packages/scss-generator, packages/icon-build-helpers and packages/cli.

@renovate renovate bot changed the title fix(deps): update dependency stylelint-prettier to v4 fix(deps): update dependency stylelint-prettier to v4 - abandoned Dec 14, 2023
Copy link
Contributor Author

renovate bot commented Dec 14, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@tay1orjones
Copy link
Member

Looks like Jest has some v30 alphas out if we want to test the bleeding edge and see if we can land this one

@tay1orjones tay1orjones removed the request for review from andreancardona April 15, 2024 16:37
@tay1orjones tay1orjones mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants