Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(types): added types for SideNavSwitcher #14739

Merged
merged 4 commits into from
Oct 19, 2023
Merged

refactor(types): added types for SideNavSwitcher #14739

merged 4 commits into from
Oct 19, 2023

Conversation

SunnyJohal
Copy link
Contributor

Closes #13608

Added Types to the SideNavSwitcher component

Changelog

New

  • Renamed file extension to .tsx
  • Added types for the component props.

Changed

  • Memoized onChange handler to prevent unnecessary re-renders

Removed

  • n/a

@SunnyJohal SunnyJohal requested a review from a team as a code owner September 29, 2023 17:56
@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 203234c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/65171e3cf5d0d700083e608d
😎 Deploy Preview https://deploy-preview-14739--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SunnyJohal SunnyJohal changed the title refactor (types): added types for SideNavSwitcher refactor(types): added types for SideNavSwitcher Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 203234c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65171e3c5045700008221813
😎 Deploy Preview https://deploy-preview-14739--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andreancardona
andreancardona approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - thank you for the contribution!

tay1orjones
tay1orjones approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 19, 2023
Merged via the queue into carbon-design-system:main with commit f593b3f Oct 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@andreancardona andreancardona andreancardona approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to SideNavSwitcher
3 participants
@SunnyJohal @tay1orjones @andreancardona