fix(datatable): remove toolbar search and menu from tab order #14397
Conversation
…tch actions are open
| @@ -257,6 +256,7 @@ const Search = React.forwardRef<HTMLInputElement, SearchProps>(function Search( | |||
| type={type} | |||
| value={value} | |||
| tabIndex={onExpand && !isExpanded ? -1 : undefined} | |||
| {...rest} | |||
There was a problem hiding this comment.
I'm not sure why we had this placed before all the existing props. Props passed by consumers would always be overwritten by what we had here.
It's possible this could cause some unintended effects downstream, but I don't think it's necessarily a breaking change. Thoughts?
There was a problem hiding this comment.
Is the only "unintended effect" that props users were passing and expecting to work will now actually work? 😅
There was a problem hiding this comment.
I don't think this is breaking either, more like a bug fix for something that should have been working.
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@tay1orjones just needs updated snaps |
b7abe20
This removes the table toolbar search and menu actions from the tab order when batch actions are open, as discussed in #14357 (comment)
Changelog
Changed
...restafter other propsTesting / Reviewing
datatable.focus.batch.actions.mov