Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ComboBox): add @avt tests #14396

Merged
merged 2 commits into from
Aug 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions e2e/components/ComboBox/ComboBox-test.avt.e2e.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
/**
* Copyright IBM Corp. 2016, 2023
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const { expect, test } = require('@playwright/test');
const { visitStory } = require('../../test-utils/storybook');

test.describe('ComboBox @avt', () => {
test('accessibility-checker combobox', async ({ page }) => {
await visitStory(page, {
component: 'ComboBox',
id: 'components-combobox--default',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('ComboBox');
});

// Skipping now due to AVT violation, possible false positive
test.skip('accessibility-checker open combobox', async ({ page }) => {
await visitStory(page, {
component: 'ComboBox',
id: 'components-combobox--default',
globals: {
theme: 'white',
},
});
const combobox = page.getByRole('combobox');

await expect(combobox).toBeVisible();
// Tab and open the ComboBox
await page.keyboard.press('Tab');
await expect(combobox).toBeFocused();
await page.keyboard.press('Enter');
await expect(page.getByRole('combobox', { expanded: true })).toBeVisible;
await expect(combobox).toBeFocused();

await expect(page).toHaveNoACViolations('ComboBox-open');
});

test('combobox - keyboard nav', async ({ page }) => {
await visitStory(page, {
component: 'ComboBox',
id: 'components-combobox--default',
globals: {
theme: 'white',
},
});
const combobox = page.getByRole('combobox');
const menu = page.getByRole('listbox');
const clearButton = page.getByRole('button', {
name: 'Clear selected item',
});
const optionOne = page.getByRole('option', {
name: 'An example option that is really long to show what should be done to handle long text',
});
const optionTwo = page.getByRole('option', {
name: 'Option 2',
});

await expect(combobox).toBeVisible();
await expect(clearButton).not.toBeVisible();
// Tab and open the ComboBox with Arrow Down
await page.keyboard.press('Tab');
await expect(combobox).toBeFocused();
await page.keyboard.press('ArrowDown');
await expect(menu).toBeVisible();
// Close with Escape, retain focus, and open with Spacebar
await page.keyboard.press('Escape');
await expect(menu).not.toBeVisible();
await expect(combobox).toBeFocused();
await page.keyboard.press('Space');
await expect(menu).toBeVisible();
// Close and clear with Escape, retain focus, and open with Enter
await page.keyboard.press('Escape');
await page.keyboard.press('Escape');
await expect(menu).not.toBeVisible();
await expect(combobox).toBeFocused();
await page.keyboard.press('Enter');
await expect(menu).toBeVisible();
// Navigation inside the menu
// move to first option
await page.keyboard.press('ArrowDown');
await expect(optionOne).toHaveClass(
'cds--list-box__menu-item cds--list-box__menu-item--highlighted'
);
// select first option (should only select with enter)
await page.keyboard.press('Space');
await expect(combobox).toHaveValue(' ');
await page.keyboard.press('Enter');
await expect(combobox).toHaveValue(
'An example option that is really long to show what should be done to handle long text'
);
// focus comes back to the toggle button after selecting
await expect(combobox).toBeFocused();
await expect(menu).not.toBeVisible();
await expect(clearButton).toBeVisible();
// should only clear selection when escape is pressed when the menu is closed
await page.keyboard.press('Escape');
await expect(clearButton).not.toBeVisible();
await expect(combobox).toHaveValue('');
// should highlight menu items based on text input
await page.keyboard.press('2');
await expect(menu).toBeVisible();
await expect(optionTwo).toHaveClass(
'cds--list-box__menu-item cds--list-box__menu-item--highlighted'
);
// Should select and populate combobox with current filtered item
await page.keyboard.press('Enter');
await expect(combobox).toHaveValue('Option 2');
});
});
15 changes: 2 additions & 13 deletions e2e/components/ComboBox/ComboBox-test.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

'use strict';

const { expect, test } = require('@playwright/test');
const { test } = require('@playwright/test');
const { themes } = require('../../test-utils/env');
const { snapshotStory, visitStory } = require('../../test-utils/storybook');
const { snapshotStory } = require('../../test-utils/storybook');

test.describe('ComboBox', () => {
themes.forEach((theme) => {
Expand All @@ -31,15 +31,4 @@ test.describe('ComboBox', () => {
});
});
});

test('accessibility-checker @avt', async ({ page }) => {
await visitStory(page, {
component: 'ComboBox',
id: 'components-combobox--default',
globals: {
theme: 'white',
},
});
await expect(page).toHaveNoACViolations('ComboBox');
});
});
Loading