Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ComboBox): add @avt tests #14396

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Aug 4, 2023

Closes #14214

Adds in AVT tests for ComboBox as well as basic keyboard functionality tests

Changelog

New

  • ComboBox-test.avt.e2e.js

Changed

  • Removed @avt blocks from other test file

Testing / Reviewing

Ensure all tests pass and covers all keyboard interactions

@tw15egan tw15egan requested a review from a team as a code owner August 4, 2023 16:56
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0f0e4a6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64cd2dcd5439640008fc27cf
😎 Deploy Preview https://deploy-preview-14396--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0f0e4a6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64cd2dcddff5cc0008fb00a7
😎 Deploy Preview https://deploy-preview-14396--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 97d711d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64d128bd3170ab0008594ea8
😎 Deploy Preview https://deploy-preview-14396--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 97d711d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64d128bdb64b090008082f1f
😎 Deploy Preview https://deploy-preview-14396--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@tay1orjones tay1orjones added this pull request to the merge queue Aug 7, 2023
Merged via the queue into carbon-design-system:main with commit 2bd7a47 Aug 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for ComboBox states: Hover/Active/Visited state, Error state
3 participants