test(Select): add @avt tests #14380
Merged
test(Select): add @avt tests #14380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
reviewed
Aug 2, 2023
| await expect(select).toBeFocused(); | ||
| await expect(select).toHaveValue(''); | ||
| // Select Option 4 | ||
| await select.selectOption('option-4'); |
There was a problem hiding this comment.
Nice! I didn't know Playwright had this built into the API
tay1orjones
approved these changes
Aug 2, 2023
alisonjoseph
approved these changes
Aug 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Aug 5, 2023
55bb7f3
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14368
Adds in AVT test for
Selectas well as some basic keyboard testsChangelog
New
Select-test.avt.e2e.jsChanged
.avtfileRemoved
SelectSkeletonstory that was causing an a11y violationTesting / Reviewing
Ensure all tests pass and keyboard coverage is sufficient