Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVT] - StructuredList test #14375

Merged
merged 18 commits into from
Aug 28, 2023
Merged

[AVT] - StructuredList test #14375

merged 18 commits into from
Aug 28, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Aug 2, 2023

Closes #14326

Added AVT test for StructuredList and fixed violations on storybook.

Changelog

New

  • New test file: e2e/components/StructuredList/StructuredList-test.avt.e2e.js
  • Added aria-busy to fix violation
  • Added aria-label to fix violation

Removed

  • Removed a column without content to fix violation.

Testing / Reviewing

  • Ensure the tests pass and the keyboard navigation is covered for the selection variant.

@guidari guidari requested a review from a team as a code owner August 2, 2023 14:06
@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84eda97
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64ec8af8f15e700008bf6c87
😎 Deploy Preview https://deploy-preview-14375--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 84eda97
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ec8af8f69bcc000840a49d
😎 Deploy Preview https://deploy-preview-14375--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andreancardona
andreancardona approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

tay1orjones
tay1orjones approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I'm sorry for the delay here, totally missed this notification!

packages/react/src/components/StructuredList/StructuredList.stories.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 17, 2023
@guidari guidari enabled auto-merge August 17, 2023 15:26
@guidari guidari added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@guidari guidari enabled auto-merge August 17, 2023 16:46
@guidari guidari added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@guidari guidari added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@guidari guidari added this pull request to the merge queue Aug 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 17, 2023
@guidari guidari enabled auto-merge August 18, 2023 15:04
@guidari guidari requested a review from a team as a code owner August 21, 2023 12:59
@guidari guidari added this pull request to the merge queue Aug 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2023
@guidari guidari added this pull request to the merge queue Aug 22, 2023
@guidari guidari removed this pull request from the merge queue due to a manual request Aug 22, 2023
@guidari guidari added this pull request to the merge queue Aug 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 22, 2023
@andreancardona andreancardona added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@tw15egan tw15egan added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@guidari guidari added this pull request to the merge queue Aug 28, 2023
Merged via the queue into carbon-design-system:main with commit 4e4df51 Aug 28, 2023
17 checks passed
@guidari guidari deleted the 14326-avt-structured-list branch August 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@andreancardona andreancardona andreancardona approved these changes

Assignees
No one assigned
Labels
status: enable automerge 🟠 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for StructuredList: Default state has Invalid Role
3 participants
@guidari @tay1orjones @andreancardona