Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTableSkeleton): fix TypeScript interface #14372

Conversation

Husnain062
Copy link
Contributor

@Husnain062 Husnain062 commented Aug 1, 2023

DataTableSkeleton has a field className which should be optional:

Changed

@Husnain062 Husnain062 requested a review from a team as a code owner August 1, 2023 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@Husnain062 Husnain062 force-pushed the react-classname-optional-data-skelton branch from 88b0b22 to 0bb71c7 Compare August 1, 2023 21:57
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 88b0b22
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c97ef3662eb700086c9544
😎 Deploy Preview https://deploy-preview-14372--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 88b0b22
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c97ef389f0f400085939f9
😎 Deploy Preview https://deploy-preview-14372--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Husnain062
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4756be9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64d0e10165d30100088b603a
😎 Deploy Preview https://deploy-preview-14372--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4756be9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64d0e1017089540008ba5d2e
😎 Deploy Preview https://deploy-preview-14372--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot enabled auto-merge August 2, 2023 18:20
@Husnain062 Husnain062 force-pushed the react-classname-optional-data-skelton branch from 961e09e to d52615a Compare August 2, 2023 18:52
@github-actions github-actions bot added this pull request to the merge queue Aug 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 2, 2023
@Husnain062 Husnain062 force-pushed the react-classname-optional-data-skelton branch from b38d4ac to c56b0ab Compare August 3, 2023 16:09
@guidari guidari enabled auto-merge August 7, 2023 12:18
@guidari guidari added this pull request to the merge queue Aug 7, 2023
Merged via the queue into carbon-design-system:main with commit ffc9ab1 Aug 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants