[VITE]: Upgrade incremental-migration to use vite (FIX) #14360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Aug 1, 2023
|
@guidari that Can we try changing |
|
Now line
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to fix the failing test from #14317
The test was failing in github, but passing locally
Updated the
examples/incremental-migrationto use vite instead of nextjs.The example was getting an error before. When running with nexjs inside the monorepo it gets an error, but if we run the example outside of the monorepo it is working fine.
Also it is a good exercise to unserstand what to change when we start to migrating the CRA / NextJS examples to Vite in this issue.
Changelog
New
examples/incremental-migrationusing viteTesting / Reviewing
examples/incremental-migration-vitefolder and runyarn && yarn devIt is taking a little bit of time to first start. The same thing used to happen with the NextJS example.
I'm still trying to understand that odd behavior. 🤔
Before merge I want to get this PR up: #14219