Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datatable): add @avt tests #14357

Merged

Conversation

tay1orjones
Copy link
Member

Closes #14118

Changelog

New

  • add new avt tests for every datatable storybook story

Changed

  • updated a few stories to pass accessibility-checker

Testing / Reviewing

  • Checks should pass, double check the tests make sense

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6a3c88f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c813f7b105ca00080458ad
😎 Deploy Preview https://deploy-preview-14357--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 93fa0f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c96057c0d33b00087486dd
😎 Deploy Preview https://deploy-preview-14357--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 93fa0f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c960571cc39a0008935c59
😎 Deploy Preview https://deploy-preview-14357--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan
Copy link
Member

tw15egan commented Aug 1, 2023

@tay1orjones should we include some basic keyboard navigation tests here as well? Can probably capture most of them in the Dynamic story

@tay1orjones
Copy link
Member Author

@tw15egan Good call, I just pushed up a big block of keyboard nav related tests. This PR also now updates to the latest version of playwright so that we can use .all() to iterate through multiple elements if more than one matches a query. If testing locally (and when developing after this PR is merged) you'll need to run yarn install and then npx playwright install.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a few comments that can be addressed separate to this PR

@tay1orjones tay1orjones added this pull request to the merge queue Aug 4, 2023
Merged via the queue into carbon-design-system:main with commit 6bc6d4c Aug 4, 2023
15 checks passed
@tay1orjones tay1orjones deleted the 14118-datatable-avt branch August 4, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for DataTable states: Selection, Expanded/collapsed state
4 participants